ResidualVM logo Forum Index - ResidualVM website - Contact us - Rules Login    Register     Search curved edge
It is currently Tue Sep 17, 2019 6:50 am

All times are UTC




Post new topic Reply to topic  [ 10 posts ] 
Author Message
PostPosted: Sat Apr 13, 2019 1:35 pm 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
I get an issue when using OpenGL in window mode.
Once i resize the window the focus of the game is lost. Even worse is that it's not cured on switching back to fullscreen.

See the bug item here (SDL issue tracker for now)

Quote:
should window be resizable without FBOs?


Top
 Profile  
 
PostPosted: Sun Aug 25, 2019 4:40 pm 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
@botje and devs

I'd really like to get an answer to this, otherwise the SDL devs can't act.

Quote:
MiniGL doesn't have frame buffer objects. I tested on Linux and without FBOs, window content cannot be resized without FBOs.


Top
 Profile  
 
PostPosted: Mon Aug 26, 2019 7:31 am 
Offline
ResidualVM Developer

Joined: Thu Feb 28, 2013 5:48 pm
Posts: 192
On desktop we render directly to the default framebuffer (either a window or the full screen), no FBO is involved.
As the native resolution of the games are fixed, there is no reason to allow resizing.
There is also no code path that calls SDL_CreateWindow with the SDL_RESIZABLE flag, so the answer is a solid "no" on all fronts.


Top
 Profile  
 
PostPosted: Mon Aug 26, 2019 9:43 am 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
Botje wrote:
On desktop we render directly to the default framebuffer (either a window or the full screen), no FBO is involved.
As the native resolution of the games are fixed, there is no reason to allow resizing.
There is also no code path that calls SDL_CreateWindow with the SDL_RESIZABLE flag, so the answer is a solid "no" on all fronts.

Thanks a lot.
So, window should be permitted entirely from being resized, did i get that right?
Is that done in residualvm or must SDL take care of?


Top
 Profile  
 
PostPosted: Mon Aug 26, 2019 10:47 am 
Offline
ResidualVM Developer

Joined: Thu Feb 28, 2013 5:48 pm
Posts: 192
I think it is SDL's task to inform the OS this window does not want to be resized.


Top
 Profile  
 
PostPosted: Mon Aug 26, 2019 11:44 am 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
Thank you very much once again.

Will post here if more questions arise.


Top
 Profile  
 
PostPosted: Sat Sep 07, 2019 9:54 pm 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
Botje wrote:
There is also no code path that calls SDL_CreateWindow with the SDL_RESIZABLE flag.

Hmm, but there is, isn't there?

Please, if you got time, review the PR that deals with my issue.

Thank you very much


Top
 Profile  
 
PostPosted: Mon Sep 09, 2019 7:22 am 
Offline
ResidualVM Developer

Joined: Thu Feb 28, 2013 5:48 pm
Posts: 192
You are right. I missed the `break` statements that cause it to continue to use this window.

I do not think resizing the window does something useful on the other platforms, so maybe we should disable it altogether.


Top
 Profile  
 
PostPosted: Mon Sep 09, 2019 10:29 am 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
Botje wrote:
I do not think resizing the window does something useful on the other platforms, so maybe we should disable it altogether.

I thought so too, but didn't want to change it for all other platforms, since there might have been some other code that deals with them which i wasn't aware of.

I ill adapt the PR. (edit: done)

p.s. i don't know if a comment should be placed there, feel free to add one, if necessary.

Thank you very much


Top
 Profile  
 
PostPosted: Tue Sep 10, 2019 1:19 pm 
Offline
User avatar

Joined: Tue May 05, 2009 10:57 am
Posts: 90
Location: a story that hasn't been written yet
Fixed in-tree.

Thank you Botje and bgK


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 10 posts ] 

All times are UTC


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group
Forum design by ScummVM team, icons by raina, adopted for ResidualVM
curved edge   curved edge